Remove obsolete ruby-oci8 2.0.3 TIMESTAMP patch#261
Conversation
There was a problem hiding this comment.
Pull request overview
Removes a legacy ruby-oci8 2.0.3-specific TIMESTAMP fractional seconds patch and aligns the runtime ruby-oci8 minimum version check with the project’s stated dependency range.
Changes:
- Delete the obsolete
lib/plsql/oci8_patches.rbmonkey patch (ruby-oci8 2.0.3 only). - Remove the corresponding
require "plsql/oci8_patches"from the OCI connection loader. - Increase the runtime minimum ruby-oci8 version check from
2.0.3to2.1.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/plsql/oci8_patches.rb | Removes a legacy monkey patch targeting ruby-oci8 2.0.3. |
| lib/plsql/oci_connection.rb | Drops patch require and bumps minimum ruby-oci8 version check to 2.1.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
685f94d to
9b6d0fb
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cde4191 to
5623520
Compare
- Remove oci8_patches.rb which patched TIMESTAMP fractional seconds for ruby-oci8 2.0.3 - Bump minimum ruby-oci8 version from 2.0.3 to 2.1.0 - Use Gem::Version for version comparison - Update README to reflect current requirements Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5623520 to
b40874b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
lib/plsql/oci8_patches.rbwhich patched a TIMESTAMP fractional seconds bug specific to ruby-oci8 2.0.3 (added in 2009, fixed upstream in 2.0.4)require "plsql/oci8_patches"fromoci_connection.rb~> 2.1constraintGem::Versionfor version comparisonTest plan
🤖 Generated with Claude Code