Skip to content

Remove obsolete ruby-oci8 2.0.3 TIMESTAMP patch#261

Merged
yahonda merged 1 commit intorsim:masterfrom
yahonda:remove-obsolete-oci8-patches
Apr 13, 2026
Merged

Remove obsolete ruby-oci8 2.0.3 TIMESTAMP patch#261
yahonda merged 1 commit intorsim:masterfrom
yahonda:remove-obsolete-oci8-patches

Conversation

@yahonda
Copy link
Copy Markdown
Collaborator

@yahonda yahonda commented Apr 13, 2026

Summary

  • Remove lib/plsql/oci8_patches.rb which patched a TIMESTAMP fractional seconds bug specific to ruby-oci8 2.0.3 (added in 2009, fixed upstream in 2.0.4)
  • Remove the corresponding require "plsql/oci8_patches" from oci_connection.rb
  • Bump the runtime minimum version check from 2.0.3 to 2.1.0 to match the gemspec ~> 2.1 constraint
  • Use Gem::Version for version comparison
  • Update README to reflect current requirements

Test plan

  • Verify CI passes (the patch was dead code -- never activated with ruby-oci8 ~> 2.1)

🤖 Generated with Claude Code

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a legacy ruby-oci8 2.0.3-specific TIMESTAMP fractional seconds patch and aligns the runtime ruby-oci8 minimum version check with the project’s stated dependency range.

Changes:

  • Delete the obsolete lib/plsql/oci8_patches.rb monkey patch (ruby-oci8 2.0.3 only).
  • Remove the corresponding require "plsql/oci8_patches" from the OCI connection loader.
  • Increase the runtime minimum ruby-oci8 version check from 2.0.3 to 2.1.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/plsql/oci8_patches.rb Removes a legacy monkey patch targeting ruby-oci8 2.0.3.
lib/plsql/oci_connection.rb Drops patch require and bumps minimum ruby-oci8 version check to 2.1.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yahonda yahonda force-pushed the remove-obsolete-oci8-patches branch 3 times, most recently from 685f94d to 9b6d0fb Compare April 13, 2026 05:40
@yahonda yahonda requested a review from Copilot April 13, 2026 05:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yahonda yahonda force-pushed the remove-obsolete-oci8-patches branch from cde4191 to 5623520 Compare April 13, 2026 05:55
- Remove oci8_patches.rb which patched TIMESTAMP fractional seconds
  for ruby-oci8 2.0.3
- Bump minimum ruby-oci8 version from 2.0.3 to 2.1.0
- Use Gem::Version for version comparison
- Update README to reflect current requirements

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@yahonda yahonda force-pushed the remove-obsolete-oci8-patches branch from 5623520 to b40874b Compare April 13, 2026 05:58
@yahonda yahonda requested a review from Copilot April 13, 2026 06:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yahonda yahonda merged commit 412d59e into rsim:master Apr 13, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants