Skip to content

Simplify gemspec and remove Juwelier#245

Merged
yahonda merged 2 commits intorsim:masterfrom
yahonda:read_version_from_file
Apr 12, 2026
Merged

Simplify gemspec and remove Juwelier#245
yahonda merged 2 commits intorsim:masterfrom
yahonda:read_version_from_file

Conversation

@yahonda
Copy link
Copy Markdown
Collaborator

@yahonda yahonda commented Apr 12, 2026

Summary

  • Remove Juwelier from Gemfile
  • Simplify gemspec: read version from VERSION file, replace hardcoded s.files list with Dir[...], remove Juwelier-generated boilerplate (required_rubygems_version, s.date, s.rubygems_version, specification_version branching), and drop activerecord/oracle_enhanced-adapter from gemspec dev dependencies (managed by Gemfile)

Motivation

This simplifies the release process. Now that #240 (release workflow with trusted publishing) is merged, releasing a new version of ruby-plsql becomes:

  1. Update the VERSION file
  2. Push a v* tag

That's it — the release workflow builds the gem and publishes it to RubyGems via trusted publishing. No need for Juwelier's rake gemspec, manual gemspec version edits, or local gem push.

Both ruby-plsql.gemspec and lib/plsql/version.rb read from the VERSION file, so there is only one place to update.

Test plan

  • gem build ruby-plsql.gemspec succeeds
  • Built gem contains the expected files (lib, VERSION, License.txt, README.md, History.txt)
  • CI passes

🤖 Generated with Claude Code

@yahonda yahonda force-pushed the read_version_from_file branch from 56336e1 to 130a6e7 Compare April 12, 2026 11:47
@yahonda yahonda changed the title Read version from VERSION file in gemspec and remove Juwelier Simplify gemspec and remove Juwelier Apr 12, 2026
@yahonda yahonda force-pushed the read_version_from_file branch 2 times, most recently from 562bed9 to 51f4906 Compare April 12, 2026 16:10
yahonda and others added 2 commits April 13, 2026 01:12
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@yahonda yahonda force-pushed the read_version_from_file branch from 51f4906 to f039403 Compare April 12, 2026 16:12
@yahonda yahonda requested a review from Copilot April 12, 2026 16:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes Juwelier and simplifies the gemspec to make releases driven by the VERSION file and a minimal, deterministic file manifest.

Changes:

  • Removed juwelier from the Gemfile and gemspec-generated boilerplate.
  • Updated gemspec to read s.version from the VERSION file and use Dir[...] for packaged files.
  • Trimmed gemspec development dependencies (moving some dev deps responsibility to the Gemfile).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
ruby-plsql.gemspec Drops Juwelier boilerplate; reads version from VERSION; simplifies packaged files and dev deps.
Gemfile Removes Juwelier dependency from development group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yahonda yahonda merged commit cd0bf5d into rsim:master Apr 12, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants