Simplify gemspec and remove Juwelier#245
Merged
yahonda merged 2 commits intorsim:masterfrom Apr 12, 2026
Merged
Conversation
56336e1 to
130a6e7
Compare
562bed9 to
51f4906
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
51f4906 to
f039403
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes Juwelier and simplifies the gemspec to make releases driven by the VERSION file and a minimal, deterministic file manifest.
Changes:
- Removed
juwelierfrom the Gemfile and gemspec-generated boilerplate. - Updated gemspec to read
s.versionfrom theVERSIONfile and useDir[...]for packaged files. - Trimmed gemspec development dependencies (moving some dev deps responsibility to the Gemfile).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ruby-plsql.gemspec | Drops Juwelier boilerplate; reads version from VERSION; simplifies packaged files and dev deps. |
| Gemfile | Removes Juwelier dependency from development group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VERSIONfile, replace hardcodeds.fileslist withDir[...], remove Juwelier-generated boilerplate (required_rubygems_version,s.date,s.rubygems_version,specification_versionbranching), and drop activerecord/oracle_enhanced-adapter from gemspec dev dependencies (managed by Gemfile)Motivation
This simplifies the release process. Now that #240 (release workflow with trusted publishing) is merged, releasing a new version of ruby-plsql becomes:
VERSIONfilev*tagThat's it — the release workflow builds the gem and publishes it to RubyGems via trusted publishing. No need for Juwelier's
rake gemspec, manual gemspec version edits, or localgem push.Both
ruby-plsql.gemspecandlib/plsql/version.rbread from theVERSIONfile, so there is only one place to update.Test plan
gem build ruby-plsql.gemspecsucceeds🤖 Generated with Claude Code