Skip to content

fix default timezone#235

Open
jlahtinen wants to merge 1 commit intorsim:masterfrom
jlahtinen:fix_default_timezone
Open

fix default timezone#235
jlahtinen wants to merge 1 commit intorsim:masterfrom
jlahtinen:fix_default_timezone

Conversation

@jlahtinen
Copy link
Copy Markdown

No description provided.

@yahonda
Copy link
Copy Markdown
Collaborator

yahonda commented Apr 13, 2026

Thank you for the pull request.

This change would replace the ActiveRecord default_timezone lookup with a check on the connection's session time zone. There are a couple of concerns:

  • The current code intentionally reads ActiveRecord.default_timezone (:utc or :local) so that ruby-plsql stays consistent with how ActiveRecord interprets database values. This PR would break that integration.
  • The session time zone (connection.time_zone) and default_timezone are different concepts. A session could be set to "Asia/Tokyo" while the application still wants default_timezone: :utc.
  • The existing test "should use ActiveRecord default_timezone as default" in schema_spec.rb would fail with this change.

Could you describe the problem you were trying to solve? If there is a specific scenario where the timezone behavior is incorrect, we would be happy to look into an alternative fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants