Skip to content

Improve 18c support#208

Open
joschug wants to merge 20 commits intorsim:masterfrom
joschug:dev
Open

Improve 18c support#208
joschug wants to merge 20 commits intorsim:masterfrom
joschug:dev

Conversation

@joschug
Copy link
Copy Markdown

@joschug joschug commented Oct 27, 2021

This fixes #204, #207 and probably #200.

  • Resolve type synonyms
  • Support cross-schema type references
  • Added support for package types declared as %ROWTYPE
  • Added support for %ROWTYPE as procedure parameter
  • Exclude hidden columns from table types
  • Remap TIMESTAMP(n) WITH LOCAL TIMEZONE to TIMESTAMP WITH LOCAL TIMEZONE
  • Remap PL/SQL PLS/BINARY INTEGER to PLS_INTEGER/BINARY_INTEGER

joschug added 20 commits October 11, 2021 13:49
@joschug
Try to resolve package synonyms like utl_file.file_type
513ea0a
@joschug
Field definitions do not necessarily have to come from the current sc…
4c5959d 
…hema; the type owner should take precedence
@joschug
Split lookup against all_objects into second query; alleviates the po…
38bd95c 
…or performance
@joschug
Field definitions do not necessarily have to come from the current sc…
1f328bf 
…hema; the type owner should take precedence
@joschug
Try to resolve type synonyms - also for elements and table/view types
6befbcc
@joschug
Allow variable declarations that do not end with a semicolon
244bcd6
@joschug
18c: Resolve %ROWTYPE within an element
00ebb3d
@joschug
Merge branch '18c_allow_field_definitions_from_other_schemas' into dev
631aa40
@joschug
Merge branch '18c_public_plsql_records' into dev
afab0c1 
# Conflicts:
#	lib/plsql/procedure.rb
@joschug
Merge branch '18c_variables_without_semicolon_at_the_end_of_the_line'…
700b418 
… into dev
@joschug
Merge branch '18c_resolve_element_rowtype' into dev
907f516
@joschug
Exclude hidden columns
de8b2e5
@joschug
Fix "no implicit conversion of Time into String" if column data type is
54429b5 
"timestamp(6) with local timezone"; before 18c, this was represented as
"timestamp with local timezone"
@joschug
18c: Resolve %ROWTYPE within an element
d0d5beb
@joschug
Merge branch '18c_resolve_element_rowtype' into dev
dfcdc33 
# Conflicts:
#	lib/plsql/procedure.rb
@joschug
Make char length determination consistent
2eedc94
@joschug
Try to fix nested types - type declared inside a package, referencing…
403ef6a 
… a schema-level table type
@joschug
Map new PL/SQL types to old types
cbdc13f
@joschug
Remove debug output
0409a09
@joschug
Merge branch '18c_public_plsql_records' into dev
89e4af9
@joschug joschug changed the title Dev Improve 18c support Oct 27, 2021
This was referenced Oct 27, 2021
Closed
Closed
Open
@yahonda
Copy link
Copy Markdown
Collaborator

yahonda commented May 12, 2023

Could you please break this pull request into smaller pieces?

@Faq
Copy link
Copy Markdown

Faq commented Aug 23, 2024 •
edited
Loading

Using this for a year with Rails 5.2 and 18c, now upgraded Rails to v7.0, still works.

@yahonda
Copy link
Copy Markdown
Collaborator

yahonda commented Apr 13, 2026

Thank you for this contribution. There are several valuable fixes here for Oracle 18c and later.

To make it easier to review and merge, we are splitting the changes into smaller, focused pull requests with tests:

  • Exclude hidden columns from table type field definitions
  • Remap TIMESTAMP(n) WITH LOCAL TIME ZONE to TIMESTAMP WITH LOCAL TIME ZONE
  • Use type_owner instead of schema_name for cross-schema type references

We will reference this PR from each one.

yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Remap TIMESTAMP(n) WITH LOCAL TIME ZONE to standard form
dcca897 
Oracle 18c and later reports the data type as "TIMESTAMP(6) WITH
LOCAL TIME ZONE" in ALL_TAB_COLS, whereas older versions used
"TIMESTAMP WITH LOCAL TIME ZONE". Normalize to the standard form
to avoid type conversion errors.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Exclude hidden columns from table type field definitions
b89ab8b 
When querying ALL_TAB_COLS for table/view type parameters, hidden
columns (e.g., those created by functional indexes) were included
in the field definitions. Filter them out with hidden_column != 'YES'.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Use type_owner for cross-schema type lookups
0e03913 
The get_field_definitions and get_element_definition methods used
@schema_name when querying type metadata from ALL_PLSQL_TYPE_ATTRS,
ALL_TAB_COLS, ALL_PLSQL_COLL_TYPES, and ALL_COLL_TYPES. This fails
when a procedure parameter references a type owned by a different
schema. Use argument_metadata[:type_owner] instead.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 13, 2026
Open
Open
Open
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Exclude hidden columns from table type field definitions
9b05e70 
Use ALL_TAB_COLUMNS instead of ALL_TAB_COLS when querying column
definitions for table/view type parameters. ALL_TAB_COLUMNS excludes
hidden columns (e.g., those created by functional indexes) by default,
and is available in all supported Oracle versions including 11g.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Exclude hidden columns from table type field definitions
3bd35f2 
Use ALL_TAB_COLUMNS instead of ALL_TAB_COLS when querying column
definitions for table/view type parameters. ALL_TAB_COLUMNS excludes
hidden columns (e.g., those created by functional indexes) by default,
and is available in all supported Oracle versions including 11g.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Exclude hidden columns from table type field definitions
26a1c78 
Use ALL_TAB_COLUMNS instead of ALL_TAB_COLS when querying column
definitions for table/view type parameters. ALL_TAB_COLUMNS excludes
hidden columns (e.g., those created by functional indexes) by default,
and is available in all supported Oracle versions including 11g.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Exclude hidden columns from table type field definitions
63039de 
Use ALL_TAB_COLUMNS instead of ALL_TAB_COLS when querying column
definitions for table/view type parameters. ALL_TAB_COLUMNS excludes
hidden columns (e.g., those created by functional indexes) by default,
and is available in all supported Oracle versions including 11g.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Exclude hidden columns from table type field definitions
fd2a325 
Use ALL_TAB_COLUMNS instead of ALL_TAB_COLS when querying column
definitions for table/view type parameters. ALL_TAB_COLUMNS excludes
hidden columns (e.g., those created by functional indexes) by default,
and is available in all supported Oracle versions including 11g.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
WIP: Test hidden columns with ALL_TAB_COLS to verify test fails
ea28e73 
Temporarily revert to ALL_TAB_COLS (without hidden column filter)
to confirm the new test detects hidden columns. If the test fails,
the fix (switching to ALL_TAB_COLUMNS) is validated.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda added a commit to yahonda/ruby-plsql that referenced this pull request Apr 13, 2026
@yahonda @joschug @claude
Exclude hidden columns from table type field definitions
3759bfc 
Use ALL_TAB_COLUMNS instead of ALL_TAB_COLS when querying column
definitions for table/view type parameters. ALL_TAB_COLUMNS excludes
hidden columns (e.g., those created by functional indexes) by default,
and is available in Oracle 11g and newer.

Based on rsim#208

Co-Authored-By: Jochen Schug <4573581+joschug@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ruby-plsql 0.8.0: Procedure with parameters referencing system packages fails

3 participants

@joschug @yahonda @Faq