Open
Conversation
Member
|
Nice! I have more packages you could do this to if you'd like 😀
I'll try and get through the actual vignette soon |
Member
Author
|
I think quarantining of the style code could be achieved at the same time as my suggestion to create a workbook registration function (that treats all worksheets equally and gathers a bit of info on them), should you choose to accept it. |
added 26 commits
May 18, 2016 12:08
This is also me just exploring all the files in the unzipped xlsx. And then exposing anything that looks valuable. I'm sure this has lots of overlap with existing linen::workbook.
similar to xlsx_read_workbook() but does less: only reads from the single file xl/workbook.xml
# Conflicts: # DESCRIPTION
so I need to be more specific here
added 7 commits
May 30, 2016 22:40
# Conflicts: # DESCRIPTION # R/rexcel-package.r
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a genuine PR @richfitz. I've created a faux vignette, where I unpack all the code necessary to read the data from a workbook with one sheet. I propose this PR/vignette as a way to have a concrete conversation as I figure out how
rexcelworks. Eventually we could comment around specific lines. But first, can I get your high-level reaction?rexcel's reading could be made simpler, but of course I don't have specific proposals yet! Is that also your sense or do you think there aren't any major simplifications available?rexcel, because it's driven the current specs oflinen. This is more a comment than question.