-
-
Notifications
You must be signed in to change notification settings - Fork 52
Upgrade Deno Dependencies to Support Deno 2.6.4 and Axum 0.8+ #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
First of all I appreciate the effort that went into this and I thank you for helping me bring the project up to date People trust Rustyscript because we provide a stable API as opposed to the constant changes within deno. For example the broadcast channel wrapper was doing some important work to bridge rust types with the broadcast channel system and removing it completely because the API changed may be shortsighted I'm also confused by the kv changes. It is very difficult to get a read on what you actually changed because you appeared to have changed some formatting for just about every file you touched which means that I can't actually see what you have changed because it looks like you've changed everything The reason it takes so long to update the dependency versions is so that I can keep my API stable. |
|
Thank you for the detailed feedback and for taking the time to review this. Broadcast ChannelThe
KV ChangesThe KV changes are actually a simplification - the new FormattingYou're right about the formatting noise making the diff harder to review - I apologize for that. I should have kept formatting changes in a separate commit or avoided them entirely. For future PRs I'll be more careful about this. SummaryThe goals of this PR are:
All public APIs remain backward compatible - this should be a drop-in upgrade for existing users. |
|
Thank you for the response!
|
Summary
reqwestfrom=0.12.8to^0.12.20to resolve compatibility issues with axum 0.8+deno_corefrom0.355.0to0.376.0along with all related deno extensions.gitattributesto preserve mixed line endings in the repositoryChanges
Dependency Upgrades
Code Changes