Support for calculating element visibility in relation to parent container defined with bind-scroll-to#12
Open
mavidulin wants to merge 1 commit intorpocklin:masterfrom
Conversation
…t container defined with bind-scroll-to
Owner
|
Is it possible to add a test for the use case you mention? Can you please rebase this with master as well? |
Author
|
Do you mean adding an example? |
Owner
|
Sure an example would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you define a bind-scroll-to element (container), element visibility will be evaluated on that container. Before, only viewPort height was used, so if you had scrollable elements in a div with limited height (and hidden overflow) their visibility was still evaluated on the whole viewPort.