Make BottomBar resize when change visibility of BottomBarTab to GONE#520
Open
arturgaleno wants to merge 5 commits intoroughike:masterfrom
Open
Make BottomBar resize when change visibility of BottomBarTab to GONE#520arturgaleno wants to merge 5 commits intoroughike:masterfrom
arturgaleno wants to merge 5 commits intoroughike:masterfrom
Conversation
Collaborator
|
@arturgaleno is this still a thing on the latest version? |
Author
|
@yombunker I really don't know. But, it's very simple to reproduce that behavior. Simple create a bottom bar with xml and then set any tab to gone. The bottom bar must resize it's content appropriately. |
Collaborator
|
@arturgaleno i don't think this is how is supposed to be done, i'm pretty sure you are suppose to change the items send to the BottomBar instead of making it "gone" programmatically and expecting to resize. @roughike can you chime on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at #437
No more dynamic adding of tabs?.Was suggestioned this piece of code:
bottomBar.getTabAtPosition(x).setVisibility(View.GONE);to make tab gone dynamically.
But, when we use that, tabs don't get resized on BottomBar.
This PR comes to solve this issue and added this enhancement.
Thanks!