Expose ServiceType in Service public API#3088
Open
SayHey wants to merge 1 commit intoros2:rollingfrom
Open
Conversation
Signed-off-by: Danil <danil.nev@gmail.com>
jmachowinski
approved these changes
Mar 4, 2026
Collaborator
There was a problem hiding this comment.
I'm good with the change, but want a second opinion on the naming.
E.g. ServiceType or ServiceMsgType etc.
@fujitatomoya @mjcarroll any objections or should we just ship it ?
fujitatomoya
approved these changes
Mar 5, 2026
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
i am good to go with it.
Collaborator
|
Pulls: #3088 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR exposes
ServiceTypeinrclcpp::Servicepublic API.Is this user-facing behavior change?
Yes, the change unlocks deduction of the
ServiceTypeof an already declaredrclcpp::Serviceinstance, thus avoiding duplicating type information.Here is an example:
Usage:
Did you use Generative AI?
No