Skip to content

Use logger.warning(), f-string and super()#31

Merged
ahcorde merged 3 commits into
rollingfrom
ahcorde/rolling/improvements
Jun 16, 2026
Merged

Use logger.warning(), f-string and super()#31
ahcorde merged 3 commits into
rollingfrom
ahcorde/rolling/improvements

Conversation

@ahcorde

@ahcorde ahcorde commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Claude Opus 4.7

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested review from asymingt and mjcarroll June 15, 2026 16:19
@ahcorde ahcorde self-assigned this Jun 15, 2026
Comment thread src/rqt_shell/xterm_widget.py Outdated
@@ -68,4 +69,4 @@ def is_xterm_available():
from PyQt4.QtGui import QApplication

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we still importing PyQt4 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from asymingt June 15, 2026 18:11

@asymingt asymingt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment.

@asymingt asymingt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahcorde

ahcorde commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #31
Gist: https://gist.githubusercontent.com/ahcorde/2120c7582004da87888a6c208f5ea12b/raw/275836a19631369064d1fca438ea3395e05a43d2/ros2.repos
BUILD args: --packages-above-and-dependencies rqt_shell
TEST args: --packages-above rqt_shell
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19555

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit f83478e into rolling Jun 16, 2026
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/improvements branch June 16, 2026 13:25
@ahcorde

ahcorde commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

https://github.com/Mergifyio backport lyrical

@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown

backport lyrical

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants