Optimize include headers - #128
Open
ahcorde wants to merge 2 commits into
Open
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
asymingt
requested changes
Aug 10, 2026
asymingt
left a comment
asymingt
left a comment
There was a problem hiding this comment.
Can you ask your AI agent to stick with the public-facing interface and avoid using the headers in detail, as they may change. IMHO the brittleness added by this is not worth any performance gain.
| #include "visualization_msgs/msg/interactive_marker.hpp" | ||
| #include "visualization_msgs/msg/interactive_marker_control.hpp" | ||
| #include "visualization_msgs/msg/marker.hpp" | ||
| #include "geometry_msgs/msg/detail/quaternion__struct.hpp" |
There was a problem hiding this comment.
Is this what you wanted? I don't think we should be depending on the internal headers in /detail/.
|
|
||
| #include "visualization_msgs/msg/interactive_marker_feedback.hpp" | ||
| #include "visualization_msgs/msg/menu_entry.hpp" | ||
| #include "visualization_msgs/msg/detail/interactive_marker_feedback__struct.hpp" |
|
|
||
| #include "rmw/types.h" | ||
|
|
||
| #include "geometry_msgs/msg/detail/pose__struct.hpp" |
| #include "rclcpp/subscription_base.hpp" | ||
| #include "rclcpp/time.hpp" | ||
|
|
||
| #include "visualization_msgs/msg/detail/interactive_marker_feedback__struct.hpp" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize include headers
Reduce in my computer around 2.5s. From 22.6 s to 21.00 s
Claude Opus 4.7