Conversation
|
@maelle Thanks for the suggestion:
I've made it a separate line now which clearly states that first, followed by the strict requirement of pre-sub. Re-review requested. |
12c5c09 to
9f1adc3
Compare
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
maelle
left a comment
There was a problem hiding this comment.
Thank you! I added the news item and initial translations, let's wait for review.
|
Done Spanish. I already applied my changes. |
|
@yabellini and @maelle : I just added another change - sorry for any inconvenience!! This one will now also need to be translated. Thank you both! |
|
@mpadge this change looks unrelated to the initial PR scope, could you please
Then in that PR I'll add the translations |
That was still the last commit here, so i just removed it and force-pushed. So it's now gone, but you'll need to pull this branch again first before proceeding. |
|
And extra PR now in #1012. Thanks both! |
|
In summary, now this PR is waiting for a review of the PT translation. |
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
Co-authored-by: Francesca Palmeira <francesca@alumni.usp.br>
|
Thank you @fblpalmeira, and thank you @beatrizmilz (I 👀 the 👍 !)! No worries for any "delay". 😸 |
ropensci/software-review#767
Checklist for dev guide maintainers, do not delete 😸