add check for if query property is required#10
Open
iainkirkpatrick wants to merge 1 commit intorefactor/querysfrom
Open
add check for if query property is required#10iainkirkpatrick wants to merge 1 commit intorefactor/querysfrom
iainkirkpatrick wants to merge 1 commit intorefactor/querysfrom
Conversation
ahdinosaur
reviewed
Feb 24, 2018
| type, | ||
| required = false | ||
| } = propertyType | ||
| if (!required) return true |
Member
There was a problem hiding this comment.
this changes everything that's not required into an any type, this means you can put anything in a non-required field and it's valid. instead i think we should check if it's not required and you put a nil value, it's good.
Member
Author
There was a problem hiding this comment.
oh good thought @ahdinosaur - of course - will look at this again 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
connectthrows ifoptions.queryis a single object (rather than an array) and that object is missing any of the properties (name, service, params, id, dependencies)this adds a check for if the property is actually required - only 'service' should be
N.B. there's also a separate but related bug i think in that if you currently pass in an array of query objects for
options.query, without all the properties specified,connectdoesn't throw... i.e. the array of queries is not being asserted correctly. brain too tired to work on it more tonight tho