[RF][RS] Remove unused DebuggingSampler and DebuggingTestStat classes#22839
Open
guitargeek wants to merge 1 commit into
Open
[RF][RS] Remove unused DebuggingSampler and DebuggingTestStat classes#22839guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
These were mock implementations of the TestStatSampler and TestStatistic interfaces that returned uniform random numbers independent of the data. They were only meant for debugging the RooStats framework itself during its initial development and are referenced nowhere else in the codebase, tutorials, or tests. They were also never fully functional: DebuggingSampler's GetTestStatistic() only prints "IS NOT IMPLEMENTED" and returns a nullptr, and DebuggingTestStat leaks its data members because it lacks a destructor.
Test Results 23 files 23 suites 3d 16h 28m 16s ⏱️ Results for commit 371d352. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were mock implementations of the TestStatSampler and TestStatistic interfaces that returned uniform random numbers independent of the data. They were only meant for debugging the RooStats framework itself during its initial development and are referenced nowhere else in the codebase, tutorials, or tests.
They were also never fully functional: DebuggingSampler's GetTestStatistic() only prints "IS NOT IMPLEMENTED" and returns a nullptr, and DebuggingTestStat leaks its data members because it lacks a destructor.