[DO NOT MERGE][ntuple] Use std::string_view consistently in signatures #22835
Draft
silverweed wants to merge 4 commits into
Draft
[DO NOT MERGE][ntuple] Use std::string_view consistently in signatures #22835silverweed wants to merge 4 commits into
silverweed wants to merge 4 commits into
Conversation
the one taking string_view works as fine and it avoids ambiguities on the calling site.
Test Results 23 files 23 suites 3d 19h 3m 6s ⏱️ For more details on these failures, see this check. Results for commit 4bd55514. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
string_view_signatures
branch
from
July 17, 2026 07:30
6e7e6fc to
4bd5551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment: change all viable
const std::string &function parameters in the RNTuple library withstd::string_view. Also contextually change a few core/io function signatures and see if anything breaks.Rationale: consistent use of string_view is more optimal than
const char*/const string&due to less useless copies / string size checks / type conversions.