[gdml] Resolve material fractions by exact reference#22834
Open
agheata wants to merge 1 commit into
Open
Conversation
dpiparo
self-requested a review
July 16, 2026 11:50
dpiparo
approved these changes
Jul 16, 2026
Contributor
|
@agheata Thanks a lot for this quick fix! |
Test Results 23 files 23 suites 3d 3h 39m 7s ⏱️ Results for commit 55925d5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
GDML fraction references were resolved using names after stripping 0x... pointer suffixes. This could make an element reference resolve to an unrelated material with the same shortened name, silently producing incomplete or empty mixtures.
Changes or fixes:
Resolve fractions through the exact GDML element, material, and mixture identifiers before constructing the TGeoMixture.
A regression test covers both a pure material and an alloy whose element and material names collide after suffix stripping.
Checklist:
This PR fixes #22831