[graf2d] Further simplify freetype resource cleanup.#22807
Open
hageboeck wants to merge 2 commits into
Open
Conversation
In looking for a memory leak (which turned out to be a freetype issue [1]), it became evident that TTGlyph can actually handle its own cleanup, allowing for simplifying the code. [1] https://gitlab.freedesktop.org/freetype/freetype/-/work_items/1399
Whenever a handle to the freetype library is created, ensure that the thread-local library is initialised.
hageboeck
force-pushed
the
simplifyFreetypeCleanup
branch
from
July 14, 2026 11:06
3f029c8 to
d97297c
Compare
Test Results 23 files 23 suites 3d 14h 45m 48s ⏱️ For more details on these failures, see this check. Results for commit d97297c. ♻️ This comment has been updated with latest results. |
dpiparo
self-requested a review
July 15, 2026 06:05
dpiparo
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In looking for a memory leak (which turned out to be a freetype issue [1]), it became evident that TTGlyph can actually handle its own cleanup, allowing for simplifying the code.
[1] https://gitlab.freedesktop.org/freetype/freetype/-/work_items/1399