[ntuple][python][ATLAS experiment] Re-Implement context management pr…#22432
Open
rybkine wants to merge 1 commit into
Open
[ntuple][python][ATLAS experiment] Re-Implement context management pr…#22432rybkine wants to merge 1 commit into
rybkine wants to merge 1 commit into
Conversation
…otocol for RNTupleReader/Writer bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rntuple.py: add __enter__ method - returns self (an instance of RNTupleReader/RNTupleWriter), __exit__ method - calls RNTupleReader/RNTupleWriter destructor (if not destructed yet). tree/ntuple/test/ntuple_basics.py: update tests
rybkine
force-pushed
the
master-ntuple-python-ctx-mgr
branch
from
fcff6da to
c4e56cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…otocol for RNTupleReader/Writer
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rntuple.py: add
__enter__method - returns self (an instance of RNTupleReader/RNTupleWriter),__exit__method - calls RNTupleReader/RNTupleWriter destructor (if not destructed yet).tree/ntuple/test/ntuple_basics.py: update tests
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #22431