Draft Support for Very Large Collection#21852
Draft
pcanal wants to merge 24 commits intoroot-project:Arlesiennefrom
Draft
Draft Support for Very Large Collection#21852pcanal wants to merge 24 commits intoroot-project:Arlesiennefrom
pcanal wants to merge 24 commits intoroot-project:Arlesiennefrom
Conversation
…revious cluster's basket code. Without this all the baskets of a poorly clustered branch are retaining until the deletion of the TTree object
pcanal
requested review from
bellenot,
dpiparo,
jblomer and
linev
as code owners
Test Results 19 files 19 suites 2d 20h 5m 20s ⏱️ For more details on these failures, see this check. Results for commit c364f50. ♻️ This comment has been updated with latest results. |
In TBufferFile::ReadClass properly set the byte count returned to kOverflowCount when the byte count in the stream was not updated (was too large).
It is staying signed for historical reason since we do not plan to support collection larger than std::numeric_limit<std::int64_t>::max() as onfile we reserve the sign bit as a marker.
NOTE: this might be backward incompatible
Uses RStreamerField as a test bed for (de-)serializing large objects with TBufferFile.
pcanal
force-pushed
the
very_large_collection
branch
from
2919c36 to
c364f50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review -- just running the CI for a checkpoint.