Test CppInterOp interpreter shutdown patch #891#21847
Open
aaronj0 wants to merge 2 commits intoroot-project:masterfrom
Open
Test CppInterOp interpreter shutdown patch #891#21847aaronj0 wants to merge 2 commits intoroot-project:masterfrom
aaronj0 wants to merge 2 commits intoroot-project:masterfrom
Conversation
Re-enable llvm::InitLLVM to handle system limits and signal handlers. To avoid the "Static Destruction Order Fiasco," this patch transitions the internal interpreter registry from llvm::ManagedStatic to a heap-allocated static pointer. This ensures that the std::deque<InterpreterInfo> is not destroyed during the C-runtime exit sequence. Without this, the JIT attempts to run de-initializers (using LLVM globals) after those globals have already been cleared, leading to segfaults on Darwin and Linux. The InitLLVM which does some heavy lifting in installing handlers and bumping system limits. It is designed to work for binaries, however, since we have a pimpl pattern which isolates llvm into the CppInterOp library we need to take extra care.
Test Results 3 files 3 suites 13h 30m 44s ⏱️ For more details on these failures, see this check. Results for commit 29786d5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @vgvassilev