[cmake] cleanup leftover Makefiles and reenable some lost-coverage tests#21820
Open
ferdymercury wants to merge 25 commits intoroot-project:masterfrom
Open
[cmake] cleanup leftover Makefiles and reenable some lost-coverage tests#21820ferdymercury wants to merge 25 commits intoroot-project:masterfrom
ferdymercury wants to merge 25 commits intoroot-project:masterfrom
Conversation
ferdymercury
force-pushed
the
makefleft
branch
2 times, most recently
from
88ac0cd to
b080197
Compare
Test Results 20 files 20 suites 2d 22h 37m 10s ⏱️ For more details on these failures, see this check. Results for commit aa5a94e. ♻️ This comment has been updated with latest results. |
ferdymercury
force-pushed
the
makefleft
branch
7 times, most recently
from
25b1001 to
55eede0
Compare
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
pcanal
as code owners
ferdymercury
changed the title
ferdymercury
force-pushed
the
makefleft
branch
2 times, most recently
from
b1fb407 to
6d208b8
Compare
fix compilation
1 task
due to issues in batch mode root-project#21881
pcanal
reviewed
Apr 10, 2026
| @@ -1,4 +1,4 @@ | |||
| #! /usr/bin/env python | |||
| #! /usr/bin/env python3 | |||
Member
There was a problem hiding this comment.
Those changes seem unrelated to this PR.
Collaborator
Author
There was a problem hiding this comment.
(This file gets called by a Makefile but was not working)
pcanal
reviewed
Apr 10, 2026
| # For the licensing terms see $ROOTSYS/LICENSE. | ||
| # For the list of contributors see $ROOTSYS/README/CREDITS. | ||
|
|
||
| # @author Danilo Piparo CERN |
Member
There was a problem hiding this comment.
Suggested change
| # @author Danilo Piparo CERN |
unless accurate.
pcanal
reviewed
Apr 10, 2026
| stressKalman.cxx) | ||
|
|
||
|
|
||
| ROOT_GENERATE_DICTIONARY(TrackDict Track.h LINKDEF TrackLinkDef.h OPTIONS -inlineInputHeader) |
Member
There was a problem hiding this comment.
Since we no longer use, let remove 'TrackDict.xml`
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small step towards #9090