[tmva][sofie] Fix Conv dynamic-shape output formula when stride > 1#21730
Open
harz05 wants to merge 3 commits intoroot-project:masterfrom
Open
[tmva][sofie] Fix Conv dynamic-shape output formula when stride > 1#21730harz05 wants to merge 3 commits intoroot-project:masterfrom
harz05 wants to merge 3 commits intoroot-project:masterfrom
Conversation
sanjibansg
requested changes
Mar 29, 2026
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
Hi @harz05,
Could you add a test case for this particular scenario verifying the fix?
Thanks,
Sanjiban
Contributor
Author
|
Hello @sanjibansg, i've added a regression test in TestCustomModelsFromONXX.cxx with a Conv1d model, uses dynamic spatial dim and stride as 2; pls review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes or fixes:
In
ROperator_Conv.hxxline 202, the+1in the conv output formula(input + pad - kernel) / stride + 1was being string-concatenated onto the stride value instead of added separately, generating((W+-3)/21)for stride=2 instead of the correct((W+-3)/2+1).simple fix is to change the:
std::to_string(stride) + "1)";to+ std::to_string(stride) + "+1)";Checklist:
This PR fixes #21729