Skip to content

[clad] Test clad master#21681

Draft
vgvassilev wants to merge 1 commit intoroot-project:masterfrom
vgvassilev:clad-v2.3
Draft

[clad] Test clad master#21681
vgvassilev wants to merge 1 commit intoroot-project:masterfrom
vgvassilev:clad-v2.3

Conversation

@vgvassilev
Copy link
Copy Markdown
Member

No description provided.

@vgvassilev vgvassilev requested a review from guitargeek March 25, 2026 06:47
@guitargeek guitargeek added the clean build Ask CI to do non-incremental build on PR label Mar 25, 2026
@guitargeek
Copy link
Copy Markdown
Contributor

Adding the clean build tag - incremental builds don't rebuild Clad actually, which is why we only only se the failures on macOS so far. But I see them also locally. I'll open a reproducer on GitHub in a sec

@vgvassilev
Copy link
Copy Markdown
Member Author

Adding the clean build tag - incremental builds don't rebuild Clad actually, which is why we only only se the failures on macOS so far. But I see them also locally. I'll open a reproducer on GitHub in a sec

Looks like things now fail and I bet is the new clad master... Can you help reducing or maybe we have not landed all fixes we were supposed to..

@guitargeek
Copy link
Copy Markdown
Contributor

I opened an issue about the problem: vgvassilev/clad#1799

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Test Results

    22 files      22 suites   3d 6h 21m 50s ⏱️
 3 831 tests  3 823 ✅   1 💤 7 ❌
76 538 runs  76 391 ✅ 140 💤 7 ❌

For more details on these failures, see this check.

Results for commit ebd6e55.

♻️ This comment has been updated with latest results.

@guitargeek
Copy link
Copy Markdown
Contributor

Thanks for this! By the way, before releasing a new Clad version, it would be nice to wait until this PR is merged so we can easily test Clad master with that new neural network flow:

@vgvassilev
Copy link
Copy Markdown
Member Author

Thanks for this! By the way, before releasing a new Clad version, it would be nice to wait until this PR is merged so we can easily test Clad master with that new neural network flow:

Ok. Then I am waiting for your green light here once we have it I can release.

@vgvassilev vgvassilev closed this Mar 29, 2026
@vgvassilev vgvassilev reopened this Mar 29, 2026
@guitargeek
Copy link
Copy Markdown
Contributor

The RooFit and SOFIE gradient applications work. But it would be quite nice if the next Clad release would support also some basic RooFit Hessian examples. This is right now blocked by vgvassilev/clad#1804, which is representative for all combined fits because they use this nested function pattern.

But we have not promised the Hessians for CHEP 2026. This is just in the general 2026 plan of work. So up to you @vgvassilev if you want to release now, or if you want to do this only after fixing the Hessians. I'm fine with both, as long as there will be another Clad release planned at the end of the next quarter that we could pick up for working Hessians in ROOT 6.42!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants