[afterimage] migrate from configure-make to CMake and merge with Windows#21649
Open
ferdymercury wants to merge 19 commits intoroot-project:masterfrom
Open
[afterimage] migrate from configure-make to CMake and merge with Windows#21649ferdymercury wants to merge 19 commits intoroot-project:masterfrom
ferdymercury wants to merge 19 commits intoroot-project:masterfrom
Conversation
ferdymercury
changed the title
Member
|
Thanks for kicking off this improvement in uncharted territory! May I ask why skip-ci? Don't we maybe want to see this in action, to discover the failures not initially foreseen? |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
Now it builds as part of ROOT in my Ubu22 system |
Test Results 15 files 15 suites 2d 1h 45m 14s ⏱️ For more details on these failures, see this check. Results for commit 28b929a. ♻️ This comment has been updated with latest results. |
ferdymercury
force-pushed
the
asimagecmake
branch
2 times, most recently
from
129878d to
34bd718
Compare
otherwise afterimage might be built before eg JPEG builtin is available
ferdymercury
force-pushed
the
asimagecmake
branch
from
c1282f8 to
180ec90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-part of work towards #9090
Builds locally as standalone project as well as part of my ROOT build, on my Ubu22.