[ntuple] use only "true type name" for class members#21373
Open
jblomer wants to merge 1 commit intoroot-project:masterfrom
Open
[ntuple] use only "true type name" for class members#21373jblomer wants to merge 1 commit intoroot-project:masterfrom
jblomer wants to merge 1 commit intoroot-project:masterfrom
Conversation
Do not set the full type name as type alias. Pass only the true type name to RFieldBase::Create(). The true type name will contain Long64_t and Double32_t type name tokens, so we are still able to treat those correctly. The full type name would provide additional information. However, normalizing the full type name can cause header auto parsing. Also, the full type name, in general, cannot be used directly because it may be a type that is only valid within the class context.
Test Results 22 files 22 suites 3d 7h 31m 8s ⏱️ For more details on these failures, see this check. Results for commit 054886d. |
hahnjo
approved these changes
Feb 25, 2026
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
LGTM! One possibility for cleanup, I believe.
Do we want to backport to ROOT v6.36 to help experiments, or will this be released with 6.40 only?
|
|
||
| const auto normTypeName = ROOT::Internal::GetNormalizedUnresolvedTypeName(origTypeName); | ||
| if (normTypeName == subField->GetTypeName()) { | ||
| SetTypeAliasOf(*subField, ""); |
Member
There was a problem hiding this comment.
We can probably remove RFieldBase::SetTypeAliasOf, I think this was the only call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not set the full type name as type alias. Pass only the true type name to RFieldBase::Create(). The true type name will contain Long64_t and Double32_t type name tokens, so we are still able to treat those correctly.
The full type name would provide additional information. However, normalizing the full type name can cause header auto parsing. Also, the full type name, in general, cannot be used directly because it may be a type that is only valid within the class context.