[test] Use Python development module with warnings as errors for testing#21157
Open
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Open
[test] Use Python development module with warnings as errors for testing#21157guitargeek wants to merge 2 commits intoroot-project:masterfrom
guitargeek wants to merge 2 commits intoroot-project:masterfrom
Conversation
guitargeek
force-pushed
the
python_dev
branch
2 times, most recently
from
eb13c60 to
88c07d3
Compare
Test Results 22 files 22 suites 3d 1h 43m 59s ⏱️ For more details on these failures, see this check. Results for commit 0701b48. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
python_dev
branch
from
88c07d3 to
b622cbc
Compare
From the docs [1]: > The Python Development Mode introduces additional runtime checks that are too expensive to be enabled by default. It should not be more verbose than the default if the code is correct; new warnings are only emitted when an issue is detected. Also use the `-W error` flag to treat warnings as errors. This should help us to find bugs and problems with the tests. [1] https://docs.python.org/3/library/devmode.html
* Skip training for models without trainable weights to avoid spurious
Keras warnings about "no trainable weights"
* Suppress NumPy 2.0 __array__ DeprecationWarning during model.save()
(upstream TF/Keras compatibility issue) using a scoped warnings context
* Fix Keras inference call for single-input models by unwrapping
singleton input lists (Keras expects a tensor, not [tensor])
* Remove redundant load_weights() after load_model()
* Replace custom is_accurate() with np.testing.assert_allclose()
for clearer diagnostics and standardized comparison
* use atol=1e-2 and rtol=0 to preserve previous absolute tolerance behavior
* Update LeakyReLU argument (alpha -> negative_slope) to avoid
deprecation warnings
These changes make the tests more robust, reduce noise from external
dependencies, and significantly improve failure diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the docs [1]:
Also use the
-W errorflag to treat warnings as errors.This should help us to find bugs and problems with the tests.
[1] https://docs.python.org/3/library/devmode.html