[Math][Minuit2] Detailed documentation of Minuit2 strategies #20802
+136
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After commit 5a0ca98 introduced the Minuit strategy 3, it became apparent that a complete documentation of all the strategy differences in detail was missing, and therefore we planned to provide it in the plan of work 2025. This commit suggests to add a table to the documentation of the `MnStrategy` object, explaining each of the data members in a separate row and listing the default values for different strategy levels. This addresses the 2025 plan of work item "Update the documentation for the Minuit algorithm".
guitargeek
added
in:Documentation
in:Math Libraries
skip ci
Test Results 22 files 22 suites 3d 19h 2m 34s ⏱️ For more details on these failures, see this check. Results for commit 9a56f92. |
dpiparo
approved these changes
Jan 6, 2026
hahnjo
reviewed
Jan 8, 2026
| It can be usefult to return the uncorrected covariance matrix, even if it is not positive | ||
| definite. | ||
| One use case it to check just how far from positive-definiteness the matrix is by being able to examine the eigenvalues. |
Member
There was a problem hiding this comment.
Suggested change
| One use case it to check just how far from positive-definiteness the matrix is by being able to examine the eigenvalues. | |
| One use case is to check just how far from positive-definiteness the matrix is by being able to examine the eigenvalues. |
| This is the partner of the **HessianStepTolerance** parameter. | ||
| In some cases, it can help to set it to zero to This was found to be |
Member
There was a problem hiding this comment.
Suggested change
| In some cases, it can help to set it to zero to This was found to be | |
| In some cases, it can help to set it to zero. This was found to be |
| <td colspan="2"> | ||
| Force Hessian / covariance matrix to be positive-definite. | ||
| It can be usefult to return the uncorrected covariance matrix, even if it is not positive |
Member
There was a problem hiding this comment.
Suggested change
| It can be usefult to return the uncorrected covariance matrix, even if it is not positive | |
| It can be useful to return the uncorrected covariance matrix, even if it is not positive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit 5a0ca98 introduced the Minuit strategy 3, it became apparent that a complete documentation of all the strategy differences in detail was missing, and therefore we planned to provide it in the plan of work 2025.
This commit suggests to add a table to the documentation of the
MnStrategyobject, explaining each of the data members in a separate row and listing the default values for different strategy levels.This addresses the 2025 plan of work item "Update the documentation for the Minuit algorithm".
Work in progress - table is not complete yet