Fix tests by introducing DSL separating DDL, relations, and seeding#438
Merged
Conversation
Before that, emerging dependencies between spec parts were hard to navigate: when you call `container` it materializes the container meaning you won't be able to add new tables/relations to the container. It's a mystery to me how we've managed to continue without proper separation the stages so far. Finally, I've hit it pretty hard when fixing failing specs.
What this introduces are three DSL methods accepting blocks:
- setup_tables
- setup_relations
- seed
No setup_relations blocks are yielded before all setup_tables are run. seed blocks follow setup_relations.
These methods have an additional optional parameter for sequencing blocks within one stage:
```ruby
setup_tables(:base) {} # called first
setup_tables(dep: :base) {} # depends on base, called second
setup_tables {} # no dependency provided, will be called last
```
Also, in a given spec you can use metadata to prevent seeding or declaring relations from a shared context:
```ruby
include 'users and tasks'
describe 'a block without seeding and relations', relations: false, seeds: false do
....
end
describe 'a block without seeding', seeds: false do
....
end
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before that, emerging dependencies between spec parts were hard to navigate: when you call
container, it materializes the container, meaning you won't be able to add new tables/relations to the container. It's a mystery to me how we've managed to continue without proper separation of the stages so far. Finally, I've hit it pretty hard when fixing failing specs.What this introduces are three DSL methods accepting blocks:
No setup_relations blocks are yielded before all setup_tables are run. seed blocks follow setup_relations.
These methods have an additional optional parameter for sequencing blocks within one stage:
Also, in a given spec, you can use metadata to prevent seeding or declaring relations from a shared context: