fix: consolidate DeepCatch fixes — paper, docker, syntax, citation, gitignore, CI#1
Open
rollroyces wants to merge 1 commit into
Open
fix: consolidate DeepCatch fixes — paper, docker, syntax, citation, gitignore, CI#1rollroyces wants to merge 1 commit into
rollroyces wants to merge 1 commit into
Conversation
…itignore, ci - paper: Add missing deepcatch_final.tex (CI was referencing non-existent file) - paper: Update README to reference deepcatch_final.tex, add CI compile option - docker: Remove COPY of non-existent files (validation_framework.py, reproducibility/) - docker: Update entry point to run_full_validation.py (exists vs run_bioinfo_validation) - syntax: Fix f-string nested quote error in validation/py/run_all.py (Python 3.11) - citation: Fill in author family name, fix URL (deepcatch/deepcatch -> rollroyces/deepcatch) - gitignore: Don't ignore bundled motif_model_checkpoint.pt - ci: Update paper trigger paths to include supplementary.tex + references_final.bib - RUN_ALL.sh: Remove references to 4 missing scripts, add syntax check step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 7 issues identified during code review. All changes are backward compatible.
Fixes
🔴 paper/deepcatch_final.tex missing
compile-paper.yml) compilesdeepcatch_final.texbut file didn't existsupplementary.texandreferences_final.bibpaper/README.mdto reference correct filenames🔴 Dockerfile references non-existent files
COPY validation_framework.py— file does not exist (was never in repo)COPY reproducibility/— directory does not existvalidation/,run_full_validation.pyrun_full_validation.py(exists) instead ofrun_bioinfo_validation.py🟠 f-string syntax error in validation/py/run_all.py
f" {"=" * 58}"uses nested double quotes — SyntaxError on Python 3.11bar = "=" * 58to variable🟠 CITATION.cff — incomplete metadata
family-names: "[Last Name]"→ changed to"Lam"deepcatch/deepcatch→ corrected torollroyces/deepcatch🟠 .gitignore blocks bundled model checkpoint
*.ptignoresmodel/motif_model_checkpoint.pt— the bundled PyTorch modelmodel/*.ptwith!model/motif_model_checkpoint.ptexception🟡 RUN_ALL.sh references 4 missing scripts
run_tcga_validation.py,run_benchmark_comparison.py,validation_framework_tests.py,verify_fixes.pydo not exist🟡 Paper README mismatch
main.texandreferences.bibbut actual files aredeepcatch_final.texandreferences_final.bibTesting