Url parameter interpolation feature#22
Open
dankelleher wants to merge 1 commit intoroccomuso:masterfrom
Open
Conversation
…ike this:
```
webHooks.add('hook', URI + '/:id/abc')
```
and trigger like this:
```
webHooks.trigger('hook', {}, {}, { id: '123' })
```
Owner
|
This will be a breaking change for current api. |
Author
|
I don't think it breaks the current API, does it? Unless you have colons in your URL. Then it might break alright. How about a trigger() function that accepts (name, options) where options is an object of the form {body, headers, parameters}. This is roughly similar to how common http client libraries work, which is effectively what trigger() is anyway. |
Owner
|
it would be better, yep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows you to define webhooks like this:
and trigger like this: