Skip to content

Conversation

@Borda
Copy link
Member

@Borda Borda commented Jan 8, 2026

This pull request updates the documentation-related GitHub Actions workflows by simplifying job names, removing unnecessary matrix strategies, and improving environment variable handling. It also updates the naming conventions for better clarity and maintainability.

Workflow job and naming updates:

  • Renamed the test docs workflow from "🧪 Docs Test WorkFlow 📚" to "Test Docs Build" for clarity, and changed the job name from docs-build-test to docs-build in .github/workflows/test-doc.yml. [1] [2]
  • Renamed the deploy job from deploy to docs-build-deploy in .github/workflows/publish-docs.yml for consistency.

Simplification and cleanup:

  • Removed the matrix strategy for Python version selection in both workflows and set the Python version directly to "3.10", streamlining the configuration. [1] [2]
  • Eliminated the GitHub App token creation and direct installation of mkdocs-material-insiders via a token, simplifying dependency installation in the docs deploy workflow.

Environment and deployment improvements:

  • Updated git configuration to use the ${{ github.actor }} for user name and email, improving traceability of workflow actions.
  • Moved the MKDOCS_GIT_COMMITTERS_APIKEY environment variable into the env section for both deploy steps, making environment variable management clearer.

Copilot AI review requested due to automatic review settings January 8, 2026 12:36
@Borda Borda requested a review from SkalskiP as a code owner January 8, 2026 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes and simplifies the documentation CI workflows by removing unnecessary complexity and improving maintainability. The changes streamline job configurations and dependency management while maintaining the same core functionality.

Key changes:

  • Simplified workflow names and job identifiers for better clarity and consistency
  • Removed matrix strategies and hardcoded Python version to "3.10" to eliminate unnecessary complexity
  • Transitioned from mkdocs-material-insiders to the public mkdocs-material package, eliminating the need for GitHub App token authentication

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/test-doc.yml Updated workflow name to "Test Docs Build", renamed job from docs-build-test to docs-build, removed matrix strategy, and hardcoded Python 3.10
.github/workflows/publish-docs.yml Renamed job from deploy to docs-build-deploy, removed matrix strategy and GitHub App token creation, switched to public mkdocs-material, improved environment variable handling by moving MKDOCS_GIT_COMMITTERS_APIKEY to env section, and updated git config to use github.actor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Borda Borda enabled auto-merge (squash) January 9, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants