Skip to content

Keep NumPy type-check cap out of runtime metadata - #519

Open
cdeil wants to merge 1 commit into
roboflow:mainfrom
cdeil:fix-numpy-runtime-metadata
Open

Keep NumPy type-check cap out of runtime metadata#519
cdeil wants to merge 1 commit into
roboflow:mainfrom
cdeil:fix-numpy-runtime-metadata

Conversation

@cdeil

@cdeil cdeil commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • remove the NumPy <2.4 cap from runtime requirements
  • retain the cap in the dev extra, where it protects the Python 3.10 mypy target

Motivation

setup.py uses requirements.txt as install_requires, so the current type-check workaround is also published as runtime metadata. It prevents SDK users from resolving newer NumPy releases even though the incompatibility is in mypy parsing NumPy's newer stubs, not in the SDK runtime.

This follows the original dev-only intent discussed in #498 and #499. Moving the cap to the dev extra keeps the Python 3.10 type-check environment stable without constraining users of the SDK.

Test plan

  • Python 3.14.6 with NumPy 2.5.2: python -m unittest — 970 passed, 1 skipped
  • Python 3.10 with NumPy 2.2.6: Ruff format/lint and mypy over 72 source files pass
  • built runtime metadata requires numpy>=1.18.5; installing the dev extra applies numpy<2.4
  • git diff --check origin/main...HEAD

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedpypi/​numpy@​2.3.5 ⏵ 2.5.275 +110010010070
Updatedpypi/​matplotlib@​2.2.5 ⏵ 3.11.175 -510010010080 -9

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant