Keep NumPy type-check cap out of runtime metadata - #519
Open
cdeil wants to merge 1 commit into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<2.4cap from runtime requirementsdevextra, where it protects the Python 3.10 mypy targetMotivation
setup.pyusesrequirements.txtasinstall_requires, so the current type-check workaround is also published as runtime metadata. It prevents SDK users from resolving newer NumPy releases even though the incompatibility is in mypy parsing NumPy's newer stubs, not in the SDK runtime.This follows the original dev-only intent discussed in #498 and #499. Moving the cap to the
devextra keeps the Python 3.10 type-check environment stable without constraining users of the SDK.Test plan
python -m unittest— 970 passed, 1 skippednumpy>=1.18.5; installing thedevextra appliesnumpy<2.4git diff --check origin/main...HEAD