fix: correct positional_encoding_size type from bool to int#524
Merged
Borda merged 3 commits intoroboflow:developfrom Feb 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an incorrect type annotation for the positional_encoding_size parameter in the Backbone.__init__ method, changing it from bool = False to int = 37 to match the expected type in the DinoV2 class where it's used in arithmetic operations.
Changes:
- Corrected type annotation from
booltointforpositional_encoding_sizeparameter - Updated default value from
Falseto37
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
60b16c1 to
523f9df
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Borda
approved these changes
Feb 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #524 +/- ##
======================================
Coverage 60% 60%
======================================
Files 55 55
Lines 6993 7005 +12
======================================
+ Hits 4202 4224 +22
+ Misses 2791 2781 -10 🚀 New features to boost your workflow:
|
Borda
added a commit
that referenced
this pull request
Mar 13, 2026
* fix: correct positional_encoding_size type from bool to int --------- Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed incorrect type annotation for
positional_encoding_sizeparameter inBackbone.__init__method.Changes Made
bool = Falsetoint = 37DinoV2classTesting