Add AzureBlobStorage factory method accepting BlobServiceClient#137
Open
RicoSuter wants to merge 2 commits intorobinrodricks:developfrom
Open
Add AzureBlobStorage factory method accepting BlobServiceClient#137RicoSuter wants to merge 2 commits intorobinrodricks:developfrom
RicoSuter wants to merge 2 commits intorobinrodricks:developfrom
Conversation
Allows creating IAzureBlobStorage directly from a BlobServiceClient instance, matching the documented API in the wiki and removing the need for reflection workarounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StorageFactory.Blobs.AzureBlobStorage(blobServiceClient)extension method to createIAzureBlobStoragedirectly from aBlobServiceClientBlobServiceClientwith a native Azure connection string and pass it in, without needing reflection workaroundsNote: Wiki is outdated
The Azure Blob Storage wiki page references method names from the old Storage.NET API:
StorageFactory.Modules.UseAzureStorage()UseAzureBlobStorage()StorageFactory.Blobs.AzureBlobStorage(accountName, accountKey)AzureBlobStorageWithSharedKey(accountName, key)StorageFactory.Blobs.AzureBlobDevelopmentStorage()AzureBlobStorageWithLocalEmulator()StorageFactory.Blobs.AzureBlobStorage(client)StorageFactory.Blobs.AzureBlobStorageFromSas(sasUrl)AzureBlobStorageWithSas(sas)AccountSasPolicy(DateTime, TimeSpan)AccountSasPolicy(DateTimeOffset, TimeSpan)The wiki also doesn't document:
AzureBlobStorageWithAzureAd,AzureBlobStorageWithTokenCredential,AzureBlobStorageWithMsi, or theAzureCloudEnvironmentoverloads.