Conversation
|
I really like this, thank you @davidarny!
This is amazing progress though, am gonna jump into this a bit. Would love to collect some feedback, gonna make a post. |
562b91a to
71e5507
Compare
|
Hello @robinebers, is this still a work in progress? I just saw this and thought it gave a great look. +1 |
|
@sayuru-akash kind of yes, still needs a little bit of UI polishing. Will take care of it after a vacation. |
…e-mode # Conflicts: # src-tauri/Cargo.toml # src-tauri/src/panel.rs # src-tauri/src/webkit_config.rs # src/components/app/app-shell.tsx
@validatedev @robinebers made some UI fixes. Please take a look. |
🤖 Augment PR SummarySummary: This PR makes the new “liquid glass” look an explicit, switchable theme mode rather than always-on. Changes:
Technical Notes: Adds plugin capability 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 447429682c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
2 issues found across 19 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/app/app-shell.tsx">
<violation number="1" location="src/components/app/app-shell.tsx:68">
P2: Restore `tabIndex={-1}` on the panel container so `usePanel` can programmatically focus it.</violation>
</file>
<file name="src-tauri/tauri.conf.json">
<violation number="1" location="src-tauri/tauri.conf.json:17">
P2: This initial width of `380` will likely be overridden at runtime — `usePanel` hard-codes `PANEL_WIDTH = 400` and calls `currentWindow.setSize(...)`. Either update `PANEL_WIDTH` in the `usePanel` hook to match `380`, or keep this config at `400` to avoid a visible resize flash on launch.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
# Conflicts: # src/App.test.tsx # src/pages/settings.tsx
validatedev
left a comment
There was a problem hiding this comment.
Tried your PR with different settings. No legibility issues + looks very cool! Would be my default setting. Love it!


Summary
Glassas a separate app theme mode instead of keeping liquid glass always enabledScreenshots
Verification
cargo checkbun run buildbun run test --run src/lib/settings.test.ts src/pages/settings.test.tsx src/hooks/app/use-settings-display-actions.test.ts src/App.test.tsxbun run test --run src/components/side-nav.test.tsx src/App.test.tsxNotes
bun run test:coverageper request.