Fix required: :nullable crash when combined with as:#5636
Merged
rmosolgo merged 1 commit intoMay 19, 2026
Conversation
The auto-registered RequiredValidator was keyed by the original positional argument name, but `coerce_into_values` keys the values hash by `@keyword` (which respects `as:`). When the two differed, validation always failed; on older builds without safe-nav in `arg_keyword_to_graphql_name` it crashed with NoMethodError.
Owner
|
Sorry for the trouble on this and thanks for contributing a fix! |
Contributor
Author
No problem! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran across this issue when trying to use
as:on an argument which usedrequired: :nullable. In my version it crashes with NoMethodError but it looks like in newer versions the validation just always fails.This fix uses
@keywordinstead ofarg_name, which I think should be correct. Tests pass.