Skip to content

exec-next: Subscriptions#5589

Merged
rmosolgo merged 10 commits intomasterfrom
exec-next-subscriptions
Mar 28, 2026
Merged

exec-next: Subscriptions#5589
rmosolgo merged 10 commits intomasterfrom
exec-next-subscriptions

Conversation

@rmosolgo
Copy link
Copy Markdown
Owner

@rmosolgo rmosolgo commented Mar 25, 2026

TODO:

  • Fix argument handling. Backwards compat requires AST-style args (no as: or loads:) Currently implementation hacks into @original_arguments.
    • This could still be better, but it's clean enough for now.
  • DRY runtime subscriptions hooks into methods on GraphQL::Subscriptions
  • Decide about context.skip/null(true) -- can I keep not supporting context.skip in Execution::Next?
    • Yes, by adding a hook for gathered-up error objects to modify the response. Soon I will make this not only RuntimeError instances but also arbitrary objects -- I think @defer can be implemented that way.
  • Make tests pass with Execution::Next

@rmosolgo rmosolgo added this to the 2.5.23 milestone Mar 28, 2026
@rmosolgo rmosolgo merged commit fa35e79 into master Mar 28, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant