Conversation
Contributor
Author
|
@henhuy that's how you meant it, right? |
Contributor
Author
|
there is a naming inconsistency in #3: in setup.Choropleth it is called "name" and "title" and in the PR it is called "identifier" and "name" |
Contributor
Yes. And the handling of title and unit must be implemented in mapengine JS as well. |
Contributor
|
Ah , I see - once #3 is merged, this PR works. Okay thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waits for #3
get legend label and unit from setup in respective project settings
MAP_ENGINE_CHOROPLETHS