Skip to content

Make types and variable names clickable#3538

Merged
notxvilka merged 3 commits intorizinorg:devfrom
PremadeS:make-types-variables-clickable
Jan 18, 2026
Merged

Make types and variable names clickable#3538
notxvilka merged 3 commits intorizinorg:devfrom
PremadeS:make-types-variables-clickable

Conversation

@PremadeS
Copy link
Copy Markdown
Collaborator

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've updated the documentation with the relevant information (if needed)
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Makes types and variable names clickable in disassembly and graph widget

  • Double clicking on type, highlights the specific type in types widget. If the the type is "hidden" by the filter, only then the filter is removed and the specific type is highlighted
  • Double clicking on variable name seeks to the first read or write to the local variable in the function

Test plan (required)

  • Open any binary in Cutter
  • Go to any function and view it in disassembly or graph widget
  • Double click on type or variable name

Closing issues

closes #3253

Copy link
Copy Markdown
Contributor

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to resolve conflicts

@PremadeS PremadeS force-pushed the make-types-variables-clickable branch from 03379ca to b1ee848 Compare January 18, 2026 14:24
Copy link
Copy Markdown
Contributor

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove src/translations change. Apart from that - LGTM.

@PremadeS
Copy link
Copy Markdown
Collaborator Author

Please remove src/translations change. Apart from that - LGTM.

Accidentally added it, should be good now

@notxvilka
Copy link
Copy Markdown
Contributor

Tested and it works, thank you!

@notxvilka notxvilka merged commit 760ab0c into rizinorg:dev Jan 18, 2026
14 checks passed
@PremadeS PremadeS deleted the make-types-variables-clickable branch February 5, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make types and variables in the function name in the disassembly and graph clickable

2 participants