fix(nodejs): scope npm/npx host fallback roots#72
Open
atharvasingh7007 wants to merge 1 commit intorivet-dev:mainfrom
Open
fix(nodejs): scope npm/npx host fallback roots#72atharvasingh7007 wants to merge 1 commit intorivet-dev:mainfrom
atharvasingh7007 wants to merge 1 commit intorivet-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENOENTfrom the kernel VFSWhy
The host fallback wrapper in
packages/nodejs/src/kernel-runtime.tscurrently retries host filesystem reads after any kernel-VFS read failure. Duringnpm/npxexecution that can broaden fallback beyond npm's own installation tree instead of limiting it to npm-owned files.This change derives explicit allowed host roots from the resolved npm/npx entry package, preserves non-
ENOENTfailures from the base VFS, and removes host fallback forpwriteso the wrapper stays read-only.Validation
pnpm --filter @secure-exec/core buildpnpm --filter @secure-exec/v8 buildpnpm --filter @secure-exec/nodejs check-typespnpm --filter @secure-exec/nodejs buildpnpm --filter @secure-exec/nodejs exec vitest run test/kernel-runtime.test.ts -t "host fallback scoping"Note
pnpm --filter @secure-exec/nodejs teststill fails in this Windows checkout because the broader integration suite expectssecure-exec-v8to be available onPATHfor runtime-backed tests.