Skip to content

docs(rivetkit): remove redundant overdue schedule note#5439

Merged
NathanFlurry merged 4 commits into
mainfrom
stack/docs-rivetkit-remove-redundant-overdue-schedule-note-pkwwuxmn
Jul 20, 2026
Merged

docs(rivetkit): remove redundant overdue schedule note#5439
NathanFlurry merged 4 commits into
mainfrom
stack/docs-rivetkit-remove-redundant-overdue-schedule-note-pkwwuxmn

Conversation

@NathanFlurry

@NathanFlurry NathanFlurry commented Jul 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@claude

claude Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review

Trivial one-line docs change: removes the Overdue one-shots bullet from the "Execution behavior" list in website/src/content/docs/actors/schedule.mdx.

  • Confirmed via grep that this was the only place "overdue" was mentioned anywhere in website/src/content/docs/, so no other section becomes orphaned or inconsistent by this removal.
  • The claim of redundancy is reasonable but not airtight: the remaining Durability bullet ("schedules are durable, wake the actor on demand, and survive crashes") implies the general behavior, but the removed line called out a specific, easy-to-wonder-about case — what happens to a one-shot schedule whose fire time already passed while the actor was asleep/crashed. A reader skimming "Durability" may not immediately infer "yes, it still fires exactly once on resume, it isn't dropped." lifecycle.mdx has related language ("scheduled events are persisted and will be re-armed when the actor wakes") but doesn't explicitly cover the already-overdue-at-wake case either.
  • Consider folding that specific guarantee into the Durability bullet (e.g. "...survive crashes; overdue one-shots run when the actor resumes") rather than dropping the information outright, unless the team is confident this is sufficiently implied — worth a quick second look before merge, though this is a minor nit on an otherwise safe cleanup.

No code, tests, security, or performance surface touched — nothing else to flag.

@NathanFlurry
NathanFlurry force-pushed the stack/docs-rivetkit-use-scheduling-code-snippets-qnzppnso branch from 36a8888 to 463c4b3 Compare July 20, 2026 06:46
@NathanFlurry
NathanFlurry force-pushed the stack/docs-rivetkit-remove-redundant-overdue-schedule-note-pkwwuxmn branch from 05a8348 to 5112829 Compare July 20, 2026 06:46
@NathanFlurry
NathanFlurry changed the base branch from stack/docs-rivetkit-use-scheduling-code-snippets-qnzppnso to main July 20, 2026 08:37
@NathanFlurry
NathanFlurry merged commit 5112829 into main Jul 20, 2026
12 of 27 checks passed
@NathanFlurry
NathanFlurry deleted the stack/docs-rivetkit-remove-redundant-overdue-schedule-note-pkwwuxmn branch July 20, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant