Skip to content

fix(frontend): tighten inspector load-failure state#5423

Open
NicholasKissel wants to merge 1 commit into
mainfrom
NicholasKissel/inspector-load-error-copy
Open

fix(frontend): tighten inspector load-failure state#5423
NicholasKissel wants to merge 1 commit into
mainfrom
NicholasKissel/inspector-load-error-copy

Conversation

@NicholasKissel

Copy link
Copy Markdown
Member
  • Cuts the load-failure screen to one sentence and a single row of actions
  • Moves the legacy-inspector caveat into a tooltip on its button instead of a standing paragraph
  • Reload and legacy actions now sit side by side, so the ghost button no longer reads as a heading

@claude

claude Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review

Small, well-scoped copy/layout change. Diff matches the stated intent exactly and reuses the existing WithTooltip pattern already used elsewhere in this same file (the tab-label tooltips), so it's consistent with the component's conventions.

Code quality / correctness

  • No issues. Layout change (flex-col to flex on the button row) and removal of the standing caveat paragraph are both clean; no dangling styles or unused imports left behind.
  • WithTooltip usage matches its existing signature (trigger + content), same as the tab tooltips used earlier in this file.

Minor consideration (not blocking)

  • The "older, less secure" caveat now only surfaces on hover/focus via the Radix tooltip. Radix tooltips don't open on tap on touch devices by default, so mobile/tablet users lose that caveat entirely; they'll only see "Use legacy inspector" with no context on why it's discouraged. Since the button's own label still conveys its purpose, this is a reasonable tradeoff for the conciseness goal of the PR, but worth being aware of if the caveat is meant to actively discourage use rather than just be available on request.

Test coverage

  • No tests included, which is appropriate for a copy/layout-only change. No existing Ladle story for actor-details-iframe.tsx, so nothing to update there.

Security

  • N/A, purely presentational.

Overall looks good to merge.

@railway-app

railway-app Bot commented Jul 17, 2026

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5423 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Jul 20, 2026 at 1:19 pm
frontend-inspector 😴 Sleeping (View Logs) Web Jul 20, 2026 at 6:22 am
frontend-cloud 😴 Sleeping (View Logs) Web Jul 17, 2026 at 5:43 pm
kitchen-sink 😴 Sleeping (View Logs) Web Jul 17, 2026 at 5:42 pm
ladle ✅ Success (View Logs) Web Jul 17, 2026 at 5:37 pm
mcp-hub ✅ Success (View Logs) Web Jul 17, 2026 at 5:35 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant