test(rivetkit): re-enable gateway URL and direct-registry coverage

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(rivetkit): keep internal error exposure behavior consistent #4661
• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659 👈 (View in Graphite)
• fix(rivetkit): restore hibernatable sockets and hydrate serverless starts #4658
• fix(rivetkit-native): expose full hibernation metadata to JS #4657
• fix(pegboard): persist and replay hibernating requests #4656
• fix(guard): serialize gateway actor keys correctly #4655
• fix(api): subscribe before namespace workflow dispatch #4654
• chore(engine): publish engine bases in ci #4649 : 2 other dependent PRs (#4650 , #4652 )
• chore: lockfile lefthook #4647
• fix(rivetkit): surface native sqlite kv errors to callers #4645
• fix(rivetkit): prevent sleep races during disconnect and db work #4644
• fix(rivetkit): isolate engine envoys and propagate startup failures #4643
• test(rivetkit): remove wasm sqlite-only fixtures and coverage #4642
• chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring #4641
• chore(rivetkit): remove wasm sqlite runtime #4614
• fix(sqlite-native): restore native startup kv preload #4639
• fix(sqlite-native): delete metadata before chunk range #4638
• fix(sqlite-native): keep truncate cache coherent #4637
• fix(sqlite-vfs): use delete range for truncate cleanup #4636
• fix(sqlite-native): restore kv error hook #4635
• perf(sqlite-native): avoid cloning cached read chunks #4634
• perf(sqlite-native): gate kv operation labels #4633
• perf(sqlite-native): reuse read cache for partial writes #4632
• perf(sqlite-native): remove delete file existence probe #4631
• fix(sqlite-native): gate native read cache behind env var #4630
• fix(pegboard): isolate runner config dc lookup failures #4625 : 1 other dependent PR (#4626 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review

Overview

This PR re-enables previously commented-out gateway URL and direct-registry test coverage for raw HTTP and WebSocket connections. The old tests used direct registry endpoint access with explicit HEADER_ACTOR_QUERY headers; the new approach uses handle.getGatewayUrl() to get per-actor gateway URLs and routes requests through those. The PR also:

• Adds a warmupActor fixture to probe readiness before each test
• Adds retry logic to refreshRunnerMetadata
• Rewrites driver-engine-ping.test.ts to use the serverless runner pattern
• Updates setupTest in src/test/mod.ts to spin up a local Hono server
• Re-enables the dynamic registry variant in driver tests
• Switches engine driver tests to describe.sequential

---

Issues

Significant: Code duplication across test files

refreshRunnerMetadata, closeNodeServer, buildGatewayRequestUrl, buildGatewayWebSocketUrl, and waitForOpen are duplicated across multiple files:

• driver-engine.test.ts
• driver-engine-ping.test.ts
• src/test/mod.ts
• src/driver-test-suite/tests/raw-http-direct-registry.ts
• src/driver-test-suite/tests/raw-websocket-direct-registry.ts

The implementations have already diverged: buildGatewayWebSocketUrl in raw-websocket-direct-registry.ts handles query strings, but the version in driver-engine-ping.test.ts does not. Extracting these into a shared module would prevent further drift.

Minor: Silently swallowed refreshRunnerMetadata failure

In driver-engine.test.ts, the call is wrapped in a bare catch {}:

try {
    await refreshRunnerMetadata(...);
} catch {
    // The engine can take a while to expose the metadata refresh
    // endpoint in local test harnesses...
}

If the refresh fails for reasons other than timing (misconfiguration, wrong token, network error), tests will silently proceed and produce misleading failures. Consider logging the error, or distinguishing transient network errors from hard failures.

Minor: serverlessHandleStart non-null assertion without guard

In src/test/mod.ts at the /start route:

app.post("/start", async (ctx) => {
    return await actorDriver.serverlessHandleStart!(ctx);
});

If a driver doesn't implement serverlessHandleStart, this throws with no useful message. A guard returning a 501 would make the failure actionable. The same pattern appears in driver-engine-ping.test.ts.

Minor: Missing conn_params HTTP gateway test

The old commented-out tests included a "should handle connection parameters for authentication" case via HEADER_CONN_PARAMS. The new raw-http-direct-registry.ts skips this. The WebSocket variant does test conn params. If HTTP gateway routes support them, a test case would close the gap.

---

Positive observations

• waitForClientWarmup in utils.ts is a clean readiness barrier that replaces the previous setTimeout(250) guess.
• describe.sequential for engine driver tests is the right call for tests sharing an engine process.
• The new test structure (helper functions, httpOnlyTest conditional skip, clear names) is significantly more readable than the old commented-out block style.
• Retry logic on refreshRunnerMetadata with AbortSignal.timeout per attempt is a solid improvement over the single-shot request.
• Re-enabling the dynamic registry variant closes real coverage that was previously missing.

---

Nit: CLAUDE.md recommends antiox for TypeScript concurrency primitives. The retry loops use await new Promise((resolve) => setTimeout(resolve, 250)) directly. Not blocking for test code, but worth noting.