Skip to content

perf(sqlite-native): remove delete file existence probe #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanFlurry wants to merge 1 commit into
base: 04-12-fix_sqlite-native_gate_native_read_cache_behind_env_var
Choose a base branch
from
Open

perf(sqlite-native): remove delete file existence probe #4631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions rivetkit-typescript/packages/sqlite-native/src/vfs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@

fn read_cache_enabled() -> bool {
static READ_CACHE_ENABLED: OnceLock<bool> = OnceLock::new();

Check warning on line 108 in rivetkit-typescript/packages/sqlite-native/src/vfs.rs

View workflow job for this annotation

GitHub Actions / Rustfmt 

Diff in /home/runner/work/rivet/rivet/rivetkit-typescript/packages/sqlite-native/src/vfs.rs
*READ_CACHE_ENABLED.get_or_init(|| {
std::env::var(READ_CACHE_ENV_VAR)
.map(|value| matches!(value.to_ascii_lowercase().as_str(), "1" | "true" | "yes" | "on"))
Expand Down Expand Up @@ -270,12 +270,6 @@

fn delete_file(&self, file_tag: u8) -> Result<(), String> {
let meta_key = kv::get_meta_key(file_tag);
let resp = self.kv_get(vec![meta_key.to_vec()])?;
let value_map = build_value_map(&resp);
if !value_map.contains_key(meta_key.as_slice()) {
return Ok(());
}

self.kv_delete_range(
kv::get_chunk_key(file_tag, 0).to_vec(),
kv::get_chunk_key_range_end(file_tag).to_vec(),
Expand Down Expand Up @@ -914,7 +908,7 @@
state.batch_mode = false;
return SQLITE_IOERR;
}

Check warning on line 911 in rivetkit-typescript/packages/sqlite-native/src/vfs.rs

View workflow job for this annotation

GitHub Actions / Rustfmt 

Diff in /home/runner/work/rivet/rivet/rivetkit-typescript/packages/sqlite-native/src/vfs.rs
// Move dirty buffer entries into the read cache so subsequent
// reads can serve them without a KV round-trip.
let flushed: Vec<_> = std::mem::take(&mut state.dirty_buffer).into_iter().collect();
Expand Down
Loading