Skip to content

fix: pkg.pr.new#4598

Open
abcxff wants to merge 1 commit intomainfrom
04-09-fix_pkg.pr.new
Open

fix: pkg.pr.new#4598
abcxff wants to merge 1 commit intomainfrom
04-09-fix_pkg.pr.new

Conversation

@abcxff
Copy link
Copy Markdown
Contributor

@abcxff abcxff commented Apr 9, 2026

Description

What I changed

  • Added rlib to the crate types for rivetkit-sqlite-native so rivetkit-native can link it:
    rivetkit-typescript/packages/sqlite-native/Cargo.toml.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app bot commented Apr 9, 2026

🚅 Deployed to the rivet-pr-4598 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Apr 9, 2026 at 6:09 pm
frontend-inspector ❌ Build Failed (View Logs) Web Apr 9, 2026 at 6:01 pm
frontend-cloud ❌ Build Failed (View Logs) Web Apr 9, 2026 at 6:01 pm
kitchen-sink ❌ Build Failed (View Logs) Web Apr 9, 2026 at 6:00 pm
mcp-hub ✅ Success (View Logs) Web Apr 9, 2026 at 5:59 pm
ladle ❌ Build Failed (View Logs) Web Apr 9, 2026 at 5:59 pm

Copy link
Copy Markdown
Contributor Author

abcxff commented Apr 9, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@abcxff abcxff marked this pull request as ready for review April 9, 2026 17:58
@abcxff abcxff changed the base branch from 03-31-feat_rivetkit_gcp_log_level_format_for_rivet_compute to graphite-base/4598 April 9, 2026 17:59
@abcxff abcxff force-pushed the graphite-base/4598 branch from 8c06b67 to 7ab128e Compare April 9, 2026 17:59
@abcxff abcxff force-pushed the 04-09-fix_pkg.pr.new branch from 3fd4e36 to c1e8588 Compare April 9, 2026 17:59
@abcxff abcxff changed the base branch from graphite-base/4598 to main April 9, 2026 17:59
@abcxff abcxff requested a review from NathanFlurry April 9, 2026 18:00
@claude
Copy link
Copy Markdown

claude bot commented Apr 9, 2026

PR Review: fix: pkg.pr.new

Main Fix — sqlite-native/Cargo.toml crate-type

The primary change adds rlib to the crate types so rivetkit-native can statically link against rivetkit-sqlite-native. This is correct.

Concern: The inclusion of cdylib alongside rlib is worth clarifying.

crate-type = ["cdylib", "rlib"]
  • rlib — needed for Rust-to-Rust static linking (the stated fix)
  • cdylib — produces a C shared library, typically used for standalone native Node.js addons

If sqlite-native is only consumed as a dependency by rivetkit-native (the actual napi crate), then cdylib generates an unnecessary artifact. Per CLAUDE.md: "The native SQLite addon statically links SQLite via libsqlite3-sys with the bundled feature" — static linking points toward rlib only.

If sqlite-native is also distributed as a standalone .node addon, then cdylib is justified — but that should be documented.

index.d.tssendWsMessage / closeWebsocket signatures

-  sendWsMessage(...): void
+  sendWsMessage(...): Promise<void>

-  closeWebsocket(...): void
+  closeWebsocket(...): Promise<void>

These are breaking changes for any caller not already awaiting these methods. Since this is a low-level native bridge, callers may not check return types strictly, but it is worth auditing call sites to ensure they await the returned promise. A silently dropped rejected Promise<void> would hide errors.

Naming — notGlobal: boolean

Double-negative naming is harder to read. Prefer isGlobal: boolean (and invert call sites), or a semantically positive name like useActorScope: boolean that describes what the flag enables rather than what it disables.

jiti version bump (1.21.7 → 2.6.1)

This is a major-version jump in pnpm-lock.yaml. jiti@2.x has breaking changes from v1. Confirm that all scripts and tools consuming jiti work correctly under v2 (e.g., tsup configuration files).

Merge conflict markers in scripts/ralph/CODEX.md

Good catch removing the leftover conflict markers. These changes are unrelated to the stated fix — a follow-up or separate commit would keep the diff cleaner, but not a blocker.

Summary

Area Status
Core fix (rlib for cross-crate linking) Correct
cdylib necessity Needs clarification
Async signature changes Verify call sites await properly
notGlobal naming Consider renaming
jiti major bump Confirm compatibility
CODEX.md cleanup Good housekeeping

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 9, 2026

More templates

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4598

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4598

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4598

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4598

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4598

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4598

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4598

@rivetkit/rivetkit-native

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/rivetkit-native@4598

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4598

@rivetkit/sqlite-native

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-native@4598

@rivetkit/sqlite-wasm

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-wasm@4598

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4598

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4598

@rivetkit/engine-envoy-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-envoy-protocol@4598

commit: c1e8588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant