Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,46 @@ func Test_Client_Common(t *testing.T) {
})
})

t.Run("CancelRunningJobPollOnly", func(t *testing.T) {
t.Parallel()

config, bundle := setupConfig(t)

client, err := NewClient(NewDriverPollOnly(bundle.dbPool), config)
require.NoError(t, err)

jobStartedChan := make(chan int64)

type JobArgs struct {
testutil.JobArgsReflectKind[JobArgs]
}

AddWorker(client.config.Workers, WorkFunc(func(ctx context.Context, job *Job[JobArgs]) error {
jobStartedChan <- job.ID
<-ctx.Done()
return ctx.Err()
}))

subscribeChan := subscribe(t, client)
startClient(ctx, t, client)
riversharedtest.WaitOrTimeout(t, client.baseStartStop.Started())

insertRes, err := client.Insert(ctx, &JobArgs{}, nil)
require.NoError(t, err)

startedJobID := riversharedtest.WaitOrTimeout(t, jobStartedChan)
require.Equal(t, insertRes.Job.ID, startedJobID)

updatedJob, err := client.JobCancel(ctx, insertRes.Job.ID)
require.NoError(t, err)
require.Equal(t, rivertype.JobStateRunning, updatedJob.State)

event := riversharedtest.WaitOrTimeout(t, subscribeChan)
require.Equal(t, EventKindJobCancelled, event.Kind)
require.Equal(t, rivertype.JobStateCancelled, event.Job.State)
require.WithinDuration(t, time.Now(), *event.Job.FinalizedAt, 2*time.Second)
})

t.Run("CancelScheduledJob", func(t *testing.T) {
t.Parallel()

Expand Down
7 changes: 5 additions & 2 deletions producer.go
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,11 @@ func (p *producer) fetchAndRunLoop(fetchCtx, workCtx context.Context) {
case msg := <-p.queueControlCh:
switch msg.Action {
case controlActionCancel:
// Separate this case to make linter happy:
p.Logger.DebugContext(workCtx, p.Name+": Unhandled queue control action", "action", msg.Action)
select {
case p.cancelCh <- msg.JobID:
default:
p.Logger.WarnContext(workCtx, p.Name+": Job cancel notification dropped due to full buffer", slog.Int64("job_id", msg.JobID))
}
case controlActionMetadataChanged:
p.Logger.DebugContext(workCtx, p.Name+": Queue metadata changed", slog.String("queue", p.config.Queue), slog.String("queue_in_message", msg.Queue))
p.testSignals.MetadataChanged.Signal(struct{}{})
Expand Down