Skip to content

chore: bump Node to 24 LTS, unify CI on .nvmrc #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfazekas merged 2 commits into from
Aug 3, 2026
Merged

chore: bump Node to 24 LTS, unify CI on .nvmrc #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2209e91
chore: bump Node to 24 LTS, unify CI on .nvmrc
mfazekas Jul 29, 2026
e083f08
chore: drop the now-redundant per-job setup-node steps
mfazekas Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,6 @@ jobs:
key: ${{ runner.os }}-android-build-expo57-${{ env.ANDROID_API_LEVEL }}-${{ hashFiles('package.json', 'yarn.lock', 'android/**', 'nitrogen/generated/android/**', 'expo57-example/package.json', 'expo57-example/app.json', 'expo57-example/app.config.js', 'expo57-example/assets/**') }}
lookup-only: true

# react-native 0.86 requires node ^20.19.4 — see build-ios. Gradle also
# shells out to node for autolinking.
- name: Use Node 22
if: steps.build-cache-check.outputs.cache-hit != 'true'
uses: actions/setup-node@v4
with:
node-version: 22

- name: Install JDK
if: steps.build-cache-check.outputs.cache-hit != 'true'
uses: actions/setup-java@v4
Expand Down Expand Up @@ -199,14 +191,6 @@ jobs:
key: ${{ runner.os }}-ios-build-expo57-${{ env.XCODE_VERSION }}-${{ hashFiles('package.json', 'yarn.lock', 'ios/**', 'nitrogen/generated/ios/**', '*.podspec', 'src/specs/*.nitro.ts', 'expo57-example/package.json', 'expo57-example/app.json', 'expo57-example/app.config.js', 'expo57-example/assets/**', 'expo57-example/app/**', 'expo57-example/babel.config.js', 'expo57-example/metro.config.js') }}
lookup-only: true

# react-native 0.86 requires node ^20.19.4; .nvmrc (20.19.0) is too old
# for expo prebuild/codegen, so override node here only.
- name: Use Node 22
if: steps.build-cache-check.outputs.cache-hit != 'true'
uses: actions/setup-node@v4
with:
node-version: 22

- name: Use appropriate Xcode version
if: steps.build-cache-check.outputs.cache-hit != 'true'
uses: maxim-lobanov/setup-xcode@v1
Expand Down Expand Up @@ -287,12 +271,6 @@ jobs:
- name: Setup
uses: ./.github/actions/setup

# react-native 0.86 requires node ^20.19.4 — see build-ios.
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 22

- name: Use appropriate Xcode version
uses: maxim-lobanov/setup-xcode@v1
with:
Expand Down Expand Up @@ -520,13 +498,6 @@ jobs:
- name: Setup
uses: ./.github/actions/setup

# react-native 0.86 requires node ^20.19.4 — see build-ios. Gradle also
# shells out to node for autolinking.
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 22

- name: Install JDK
uses: actions/setup-java@v4
with:
Expand Down Expand Up @@ -623,12 +594,6 @@ jobs:
- name: Setup
uses: ./.github/actions/setup

# react-native 0.86 requires node ^20.19.4 — see build-ios.
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 22

- name: Use appropriate Xcode version
uses: maxim-lobanov/setup-xcode@v1
with:
Expand Down Expand Up @@ -856,13 +821,6 @@ jobs:
- name: Setup
uses: ./.github/actions/setup

# react-native 0.86 requires node ^20.19.4 — see build-ios. Gradle also
# shells out to node for autolinking.
- name: Use Node 22
uses: actions/setup-node@v4
with:
node-version: 22

- name: Install JDK
uses: actions/setup-java@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.19.0
v24.18.0
Loading