fix(android): allow overriding CMake version for Windows long-path builds#265
Open
mfazekas wants to merge 3 commits into
Open
fix(android): allow overriding CMake version for Windows long-path builds#265mfazekas wants to merge 3 commits into
mfazekas wants to merge 3 commits into
Conversation
…ilds On Windows the NDK default CMake (3.22.1) fails when object-file paths exceed MAX_PATH (260 chars). A newer CMake (3.31.6) handles this. Add Rive_CmakeVersion gradle property / CMAKE_VERSION env var to opt in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #263
On Windows, the Android build fails when CMake object-file paths exceed
MAX_PATH(260 chars). The NDK default CMake (3.22.1) can't handle the deeply-nested paths from Nitrogen's generated sources.This is a known issue across React Native libraries that use CMake. Adds support for the
CMAKE_VERSIONenv var (same as Reanimated) so users can opt into a newer CMake (e.g. 3.31.6) that handles long paths.