Skip to content

fix(udf): use forked ginepro to avoid leaking background LB probe task#24705

Merged
BugenZhao merged 2 commits intomainfrom
bz/monetary-hoverfly
Feb 16, 2026
Merged

fix(udf): use forked ginepro to avoid leaking background LB probe task#24705
BugenZhao merged 2 commits intomainfrom
bz/monetary-hoverfly

Conversation

@BugenZhao
Copy link
Copy Markdown
Contributor

@BugenZhao BugenZhao commented Feb 4, 2026

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Our external UDF uses the library ginepro to achieve load balancing between multiple endpoints for arrow-flight gRPC. It starts a background tokio task to continuously probe the DNS. However, the exit mechanism is not robust, resulting in resource leaks even after the executors or streaming jobs using the UDF have already been dropped.

See full changes here:

TrueLayer/ginepro#71

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@BugenZhao BugenZhao requested a review from a team as a code owner February 4, 2026 08:38
@BugenZhao BugenZhao requested review from xiangjinwu and removed request for a team February 4, 2026 08:38
@BugenZhao BugenZhao changed the title Fix(build): update ginepro dependency to risingwavelabs fork fix(udf): use forked ginepro to avoid leaking background LB probe task Feb 4, 2026
@github-actions github-actions Bot added type/fix Type: Bug fix. Only for pull requests. and removed Invalid PR Title labels Feb 4, 2026
@BugenZhao BugenZhao added this pull request to the merge queue Feb 16, 2026
Merged via the queue into main with commit e0edab4 Feb 16, 2026
34 checks passed
@BugenZhao BugenZhao deleted the bz/monetary-hoverfly branch February 16, 2026 07:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches.

hzxa21 pushed a commit that referenced this pull request Apr 2, 2026
…ask (#24705) (#25237)

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-cherry-pick-since-release-2.8 type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants