Open
Conversation
added 3 commits
September 5, 2023 10:57
lotem
reviewed
Feb 8, 2024
| } | ||
|
|
||
| -(void)changeToAsciiPrev { | ||
| if (_prev) { |
Member
There was a problem hiding this comment.
_prev does not sync with the current status from the rime session.
Between last call to changeToAscii and this one, the ascii_mode value could have changed by the user.
| return 0; | ||
| } | ||
|
|
||
| if (argc > 1 && !strcmp("--ascii_mode", argv[1])) { |
Member
There was a problem hiding this comment.
It's a one-way setting ascii_mode to true, I think we need both ways, by supplying a value:
--ascii_mode=true|fales or numeric value --ascii_mode=0|1, to be coherent with the swtich option's reset values.
| return 0; | ||
| } | ||
|
|
||
| if (argc > 1 && !strcmp("--ascii_mode_prev", argv[1])) { |
Member
There was a problem hiding this comment.
Can the caller keep track of which state should be put back in?
LEOYoon-Tsaw
force-pushed
the
master
branch
6 times, most recently
from
4346417 to
111e615
Compare
|
大佬这个merge还有下文吗，非常需要这个功能。。 |
|
同非常需要这个功能。 |
|
从 #123 到这个pr ，不知道还有没有下文( UPDATE: 似乎代码已经迁移到swift上去了 有空我考虑重新实现一下吧（ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/Library/Input\ Methods/Squirrel.app/Contents/MacOS/Squirrel --ascii_mode切换到 ascii 模式/Library/Input\ Methods/Squirrel.app/Contents/MacOS/Squirrel --ascii_mode_prev切换到之前的模式通过这个 feature 可以做到在 neovim 中更精确的控制输入法模式